[TableListView] Tries to update React state on unmonted component

[mbondyra]

Kibana version:
main

Currently there is only one listing page with 2 tabs, the visualize library.

1. Open visualize listing page and a dev console.
2. Switch from Visualization tab to annotation tab - everything works fine
3. Switch back. You'll get a react warning:

[elasticmachine]

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

[stratoula]

The problem is here https://github.com/elastic/kibana/blob/main/packages/content-management/table_list_view_table/src/table_list_view_table.tsx#L880

Moving this to the shared-ux team as they own the content management component.

[elasticmachine]

Pinging @elastic/appex-sharedux (Team:SharedUX)

[sebelga]

I will look into it but I am pretty sure we are in this scenario:
facebook/react#22114 (thanks @Dosant for sharing) which would be a "false positive".

There isn't really any memory leak, it's just a state that gets updated whenever the query params changes. Which comes from useQuery (https://github.com/elastic/kibana/blob/main/packages/content-management/table_list_view_table/src/use_url_state.ts#L37) from react-router-dom. I am pretty sure that the listener is removed whenever the component unmounts.

[EDIT]: Looks like the warning has been removed in react 18.

[vadimkibana]

Just a guess, while looking through code on GitHub: it might be solved by checking if component is still mounted before executing this state update line:

kibana/packages/content-management/table_list_view_table/src/use_url_state.ts

Line 58 in 56be6c6

setUrlState(updatedState);

[sebelga]

Just a guess, while looking through code on GitHub: it might be solved by checking if component is still mounted before executing this state update line

Yes the fix is easy. From the React issue I link it just seems that those "check if component mounted before updating state" dance might just be noise (that will be removed the day we upgrade to v18)

[sebelga]

Closing this issue as it will be fixed when upgrading to React (#181936)