Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data UI links to dashboards not working #16307

Closed
tsg opened this issue Jan 26, 2018 · 7 comments · Fixed by #16319
Closed

Add data UI links to dashboards not working #16307

tsg opened this issue Jan 26, 2018 · 7 comments · Fixed by #16319
Labels
blocker bug Fixes for quality problems that affect the customer experience

Comments

@tsg
Copy link
Contributor

tsg commented Jan 26, 2018

In Kibana 6.2.0 BC2.

To reproduce:

  • Go to the Apache metrics tutorial
  • Complete the tutorial
  • Click the "Apache metrics dashboard"

Happens:

The dashboard search page is opened with a search by the id of the dashboard. The title and the ID are different, so the search doesn't return anything:

screen shot 2018-01-26 at 11 35 51

Was expecting:

  • I was expecting a direct link to the dashboard by the ID.

I think we might have had a miss-communication based on the spec. I didn't see an ID field for the dashboards, so I put the ID in the "title" field. That could be the reason for which it doesn't work.

@nreese @alexfrancoeur

Found by @exekias.

@tsg tsg added bug Fixes for quality problems that affect the customer experience blocker labels Jan 26, 2018
@nreese
Copy link
Contributor

nreese commented Jan 26, 2018

@alexfrancoeur @tsg I am not sure that I would label this issue a blocker. The tutorial still works and kibana never crashes or gets into an error state. It is just an unfortunate bug.

What should the solution involve? Should the dashboards be identified by title or id? APM is using title.

@tsg
Copy link
Contributor Author

tsg commented Jan 26, 2018

It seems to me IDs are more precise, and can be used as a direct link, versus linking to a filtered Dashboards page, where the user needs another click. Also, we already rely on the IDs staying fixed across releases in the Beats code but have nothing in place for the titles, so those are more likely to break.

@tsg
Copy link
Contributor Author

tsg commented Jan 26, 2018

Pinging @roncohen and @makwarth for awareness.

@makwarth
Copy link

IDs would be great to use instead of title.
@tsg To be clear, if you have loaded the APM dashboards, the APM "launch" button will take you straight to the actual [APM] Services dashboard.

@alexfrancoeur
Copy link

How is this currently implemented, are we using this new URL parameter? #14760 Given the behavior, I have a feeling that we are. If we're taking this approach, providing a title instead of a ID would redirect directly to the dashboard if there is a single match. Otherwise, we then present you with the list view and search results. If we're taking this approach and searching for the ID, we'll never locate the dashboard.

While it may not crash Kibana or get into an error state, it severely disrupts the end user experience. The last step of the workflow is to navigate to a dashboard. If instead we link them to a filtered dashboard view that does not even contain a dashboard, I'd consider this is a blocker.

We just had a blocker for making a few adjustments to the Netflow tutorials (#16300). With that being that case, I definitely think we should resolve this before 6.2. Whichever approach we decide upon, we should be consistent across tutorials. One thing to consider is that it's possible there may be dashboards with the same title, but different ID's. I would consider this more of an edge case though.

@nreese
Copy link
Contributor

nreese commented Jan 26, 2018

ok, I will make the changes to use id instead of title.

@tsg are all of your tutorials using id already?

@makwarth How about APM, does that value need to be updated to the id? What is the APM dashboard id?

@tsg
Copy link
Contributor Author

tsg commented Jan 26, 2018

@nreese Yes, all Beats tutorials have the IDs. I wrote the ID of the APM dashboard in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants