Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize individual timeRange not working properly #16823

Closed
timroes opened this issue Feb 20, 2018 · 1 comment · Fixed by #17123
Closed

Visualize individual timeRange not working properly #16823

timroes opened this issue Feb 20, 2018 · 1 comment · Fixed by #17123
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@timroes
Copy link
Contributor

timroes commented Feb 20, 2018

The way individual time ranges are handled for visualizations is somewhere between kind of broken and broken.

You can currently specify a timeRange when embedding a visualization using the loader (i.e. the way you should embed a visualization), so that the visualization should use that time range instead of the global one defined by the time picker.

We currently read this out in visualize.js and attach it to the search source, that is passed to the request handler. Since the searchSource is only used by the courier request handler and not others (TSVB, timelion, Vega), those will need different access to the configured time range.

Earlier we set it to vis.params.timeRange and those request handler checked this one before accessing the global time range. Since #15998 we rather attach a method to vis, that should (but currently isn't) be used from within the different request handlers. That's also why currently all those non default request handlers are broken for individual time ranges.

I think it would make more sense to explicitly pass the time range to the request handler, instead of attaching this to the vis object.

This issue is related to #16641 in a way that we should also consider always requiring to specify the time range via the loader and not pass it via searchSource inheritance, that would anyway be ignored by non default request handlers.

@timroes timroes added bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Feb 20, 2018
@timroes
Copy link
Contributor Author

timroes commented Mar 9, 2018

We should also define, in what format requests handlers should expect the actual timeRange value to be. Currently it seems like every request handler expects it in a slightly different format, which means that would anyway never ever have worked properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant