Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters applied to visualizations are lost when viewing on a dashboard #17644

Closed
stacey-gammon opened this issue Apr 10, 2018 · 1 comment · Fixed by #17713
Closed

Filters applied to visualizations are lost when viewing on a dashboard #17644

stacey-gammon opened this issue Apr 10, 2018 · 1 comment · Fixed by #17713
Assignees
Labels
blocker Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) regression v6.3.0

Comments

@stacey-gammon
Copy link
Contributor

To repro:

  1. Create a pie chart with a filter on it, say bytes:0
  2. Add that visualization to a dashboard. See all bytes.

Confirmed broken in master, and works in 6.2.3. Probably broken in 6.3 and a blocker.

cc @elastic/kibana-visualizations

@stacey-gammon stacey-gammon added blocker Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) :Sharing labels Apr 10, 2018
@stacey-gammon
Copy link
Contributor Author

Have not confirmed but I suspect #17123

I think this line is overriding existing filter pills

See before that line:

screen shot 2018-04-10 at 3 54 51 pm

And after that line, the Watch output:
screen shot 2018-04-10 at 3 55 05 pm

And if I comment it out, it works (well the filter pill is applied, though commenting it out probably breaks something else).

This also clearly identified a gap in our tests. _dashboard_queries functional tests have tests for queries on a visualization, and links to saved searches, but none for a filter pill.

cc @timroes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:Dashboard Dashboard related features Feature:Visualizations Generic visualization features (in case no more specific feature label is available) regression v6.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants