Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] [Rule Form v2] Search source alert tests depend on Stack Management application #179702

Open
Tracked by #175634
Zacqary opened this issue Mar 29, 2024 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects

Comments

@Zacqary
Copy link
Contributor

Zacqary commented Mar 29, 2024

Changes to the rule creation flow in Stack Management broke Discover tests related to the search source alert. This PR affected only the UI for Stack Management and Observability, but ultimately triggered codeowner review from Discover because of this test dependency.

In x-pack/test/functional_with_es_ssl/apps/discover_ml_uptime/discover/search_source_alert.ts (and its test_serverless equivalent), there are several places where this line of code is called:

await PageObjects.common.navigateToApp('management');

The tests appear to be doing this to create a rule, which then gets evaluated.

It's not sustainable for Discover tests to be dependent on a different application, especially with the work we're doing on Rule Flow V2. This test will likely break again in the future for changes unrelated to Discover. Therefore, we need to keep this test in the Discover app entirely, or to have it create rules through API calls.

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Mar 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@kibanamachine kibanamachine added this to Inbox in Discover Mar 29, 2024
@Zacqary Zacqary changed the title [Discover] [Rule Flow v2] Search source alert tests depend on Stack Management application [Discover] [Rule Form v2] Search source alert tests depend on Stack Management application Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

3 participants