Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Prioritize fields based on ecs information on the editor #181036

Open
stratoula opened this issue Apr 17, 2024 · 6 comments
Open

[ES|QL] Prioritize fields based on ecs information on the editor #181036

stratoula opened this issue Apr 17, 2024 · 6 comments
Labels
enhancement New value added to drive a business result Feature:ES|QL impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana

Comments

@stratoula
Copy link
Contributor

stratoula commented Apr 17, 2024

Describe the feature:

Right now, we are suggesting fields based on the alphabetical order. In case of ECS we want to suggest first the fields that are defined in the schema.

I think the logic of retrieving this ECS schema logic should live outside the editor, possibly on a package.

@stratoula stratoula added enhancement New value added to drive a business result impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:ES|QL Team:ESQL ES|QL related features in Kibana labels Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon
Copy link
Contributor

drewdaemon commented Apr 17, 2024

I think the logic of retrieving this ECS schema logic should live outside the editor, possibly on a package.

@kertal this need dovetails nicely with your ECS field-descriptions PoC

@drewdaemon
Copy link
Contributor

drewdaemon commented Apr 17, 2024

Right now, ECS info is available as an in-memory browser bundle. However, the @elastic/kibana-data-discovery team has discussed making a server-side API for retrieving ECS data in more efficient, specific way.

@stratoula
Copy link
Contributor Author

yes I would love to use this here

@kertal
Copy link
Member

kertal commented Apr 17, 2024

Yes, this is something we should discuss, so what I did was doing a POC for a browser side solution (problem: async bundle size additions, and a push back on making it a shared dependency)
#180230
And a follow up to figure out, what happens when moving it to server side, no bundle size issues (but also not mergable)
#180543

@kertal
Copy link
Member

kertal commented May 10, 2024

FYI, another intiative related to this topic: https://github.com/elastic/observability-dev/issues/3331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

4 participants