Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] investigate execution context #181511

Open
Tracked by #167429
nreese opened this issue Apr 24, 2024 · 2 comments
Open
Tracked by #167429

[dashboard] investigate execution context #181511

nreese opened this issue Apr 24, 2024 · 2 comments
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@nreese
Copy link
Contributor

nreese commented Apr 24, 2024

dashboard execution context and coreStart.executionContext.get() provide different values
Screenshot 2024-04-23 at 10 04 28 AM

Investigate history of dashboardContainer.executionContext and see how its changed since first implemented in #107523
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas project:embeddableRebuild labels Apr 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

Extra bit of complexity here is that the o11y embeddables that use execution context use it to check if their component is being rendered inside of a Dashboard or not in order to change some UI elements around. Likely we could change this to check the parent API instead.

@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels May 8, 2024
@ThomThomson ThomThomson mentioned this issue May 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nreese @ThomThomson @elasticmachine