Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataDiscovery] Turn off bsearch in Serverless #181938

Open
thomasneirynck opened this issue Apr 29, 2024 · 1 comment
Open

[DataDiscovery] Turn off bsearch in Serverless #181938

thomasneirynck opened this issue Apr 29, 2024 · 1 comment
Assignees
Labels
Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects

Comments

@thomasneirynck
Copy link
Contributor

Describe the feature:

Turn off the use of bsearch in Serverless for Dashboards. Retain default behavior for Cloud and Stateful.

Turning off this should also include minimize the work on kibana server, by eliminating the custom base64 encoding logic.

The data should remain compressed. Consider default gzip-compression. Consider having Elasticsearch compress the response (https://www.elastic.co/guide/en/elasticsearch/client/javascript-api/current/basic-config.html) and just streaming back the data.

Describe a specific use case for the feature:

The proxy already supports a http2 connection, so the browser->proxy connection does not need the bsearch work-around.

This would be a good test run to validate a few key assumptions:

  • browser will use http2 multiplexing to avoid default browser connection limit
  • base64n compression overhead can be eliminated, eliminating the majority of work on kibana server.

proxy->kibana-server connection would remain http1. The assumption is that the overhead of multiple http-handshakes on kibana-server is minimal compared to the overhead of compression and client-side batching.

@thomasneirynck thomasneirynck added the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) label Apr 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kibanamachine kibanamachine added this to Inbox in Discover Apr 29, 2024
@lukasolson lukasolson changed the title [DataDiscovery] Turn of bsearch in Serverless [DataDiscovery] Turn off bsearch in Serverless May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
No open projects
Development

No branches or pull requests

3 participants