Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Response Ops][Alerting] Don't allow any type in triggers_actions_ui plugin #182895

Open
ymao1 opened this issue May 8, 2024 · 2 comments
Open

[Response Ops][Alerting] Don't allow any type in triggers_actions_ui plugin #182895

ymao1 opened this issue May 8, 2024 · 2 comments
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@ymao1
Copy link
Contributor

ymao1 commented May 8, 2024

We have a linting rule to disallow usage to the any type in the alerting plugin but we don't enforce it in the triggers_actions_ui plugin. Maybe we should? Doing a quick search, I see 142 usages of any in the plugin code.
@ymao1 ymao1 added Feature:Alerting technical debt Improvement of the software architecture and operational architecture Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels May 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 mentioned this issue May 8, 2024
Merged
@cnasikas
Copy link
Member

cnasikas commented May 9, 2024

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cnasikas @ymao1 @elasticmachine