Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Links] 'Update Link' Reverts Disabled Options Back to Default Settings #186044

Closed
Erikg346 opened this issue Jun 11, 2024 · 2 comments · Fixed by #178670
Closed

[Links] 'Update Link' Reverts Disabled Options Back to Default Settings #186044

Erikg346 opened this issue Jun 11, 2024 · 2 comments · Fixed by #178670
Assignees
@nickpeihl
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Erikg346
Copy link

Kibana version:
8.14.0
Elasticsearch version:
8.14.0

Describe the bug:

Steps to reproduce:

  1. Add links panel
  2. Add one dashboard
  3. Disable settings
  4. Save
  5. Click into Edit Links
  6. Disable settings are there as expected
    7, Click "Update Link"
  7. Save
  8. Click into 'Edit Links'
    7, Settings are Enabled

Expected behavior:

The disabled settings should stick if you click on 'Update Links'

Screenshots (if relevant):

Recording.2024-06-11.120438.mp4

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:
@Erikg346 Erikg346 added the bug Fixes for quality problems that affect the customer experience label Jun 11, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 11, 2024
@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Jun 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 11, 2024
@Heenawter
Copy link
Contributor

Heenawter commented Jun 11, 2024 •
edited
Loading

It's possible that #178670 might "accidentally" fix this bug... Linking that PR to this issue (pun intended) so that I will remember to check this once that PR is open for review again 👀

@Heenawter Heenawter mentioned this issue Jul 3, 2024
Merged
@Heenawter Heenawter linked a pull request Jul 3, 2024 that will close this issue
[Links] Migrate Links panel to the React embeddable framework #178670
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickpeihl nickpeihl

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Links] Migrate Links panel to the React embeddable framework nickpeihl/kibana
4 participants
@nickpeihl @Heenawter @elasticmachine @Erikg346