Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Improve synthetics alerting #186585

Open
wants to merge 40 commits into
base: main
Choose a base branch
from

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 21, 2024

Summary

Fixes #175298

Improve synthetics alerting !!

User will be able to create custom synthetics status alert by defining three kind of criteria

Monitor is down over last consective checks with threshold

image

From Locations threshold

Will be considered down only when from defined number of locations

image

Over time with checks threshold just like uptime custom status alert

image

@shahzad31
Copy link
Contributor Author

/ci

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31
Copy link
Contributor Author

/ci

1 similar comment
@shahzad31
Copy link
Contributor Author

/ci

@shahzad31
Copy link
Contributor Author

/ci

@dominiqueclarke dominiqueclarke self-requested a review July 16, 2024 13:18
@shahzad31
Copy link
Contributor Author

/ci

@shahzad31
Copy link
Contributor Author

/ci

@shahzad31
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 19, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #28 / Synthetics API Tests GetMonitorsOverview accepts search queries
  • [job] [logs] FTR Configs #28 / Synthetics API Tests GetMonitorsOverview accepts search queries

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 914 1079 +165

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 854.8KB 1.1MB ⚠️ +247.7KB
triggersActionsUi 1.7MB 1.7MB +119.0B
total +247.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 19.4KB 21.7KB +2.3KB
Unknown metric groups

API count

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

async chunk count

id before after diff
synthetics 8 9 +1

ESLint disabled line counts

id before after diff
synthetics 84 83 -1

Total ESLint disabled count

id before after diff
synthetics 91 90 -1

History

@elastic elastic deleted a comment from kibana-ci Jul 19, 2024
@shahzad31 shahzad31 marked this pull request as ready for review July 19, 2024 15:37
@shahzad31 shahzad31 requested review from a team as code owners July 19, 2024 15:37
@shahzad31 shahzad31 added release_note:enhancement release_note:feature Makes this part of the condensed release notes labels Jul 19, 2024
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps changes LGTM!

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Jul 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jul 22, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / step select agent policy should not select agent policy by default if multiple exists
  • [job] [logs] Jest Tests #15 / step select agent policy should select agent policy by default if one exists
  • [job] [logs] FTR Configs #24 / Synthetics API Tests SyntheticsSuggestions returns the suggestions
  • [job] [logs] FTR Configs #24 / Synthetics API Tests SyntheticsSuggestions returns the suggestions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 913 1078 +165

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 854.5KB 1.1MB ⚠️ +247.7KB
triggersActionsUi 1.7MB 1.7MB +119.0B
total +247.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 19.5KB 21.7KB +2.3KB
Unknown metric groups

API count

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

async chunk count

id before after diff
synthetics 8 9 +1

ESLint disabled line counts

id before after diff
synthetics 84 83 -1

Total ESLint disabled count

id before after diff
synthetics 91 90 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:project-deploy-observability Create an Observability project release_note:enhancement release_note:feature Makes this part of the condensed release notes Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please bring back the option to create segregated synthetic alert rules for each of our synthetic monitors.
6 participants