-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection: Adds popover links menu to anomaly explorer charts. #186587
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/ml-ui (:ml) |
.on('click', function (d) { | ||
d3.event.preventDefault(); | ||
if (d.anomalyScore === undefined) return; | ||
showAnomalyPopover(d, this); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you enable the popover on multi-bucket markers too? This is already supported in the Single Metric Viewer chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7829012.
anomaly={this.state.popoverData} | ||
bounds={this.props.bounds} | ||
showMapsLink={false} | ||
showViewSeriesLink={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in db0bd6f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time range is being passed correctly. But now I'm seeing that the partition field is often not set correctly in the SMV. Happens from the Anomaly Explorer or the embeddable.
@@ -108,6 +126,53 @@ const AnomalyChartsContainer: FC<AnomalyChartsContainerProps> = ({ | |||
error, | |||
} = useAnomalyChartsData(api, services, chartWidth, severity.val, renderCallbacks); | |||
|
|||
const dateFormatTz = useDateFormatTz(); | |||
|
|||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a race condition because in some places mlJobService
was still used via dependency cache. Should be fixed in e35c568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can still reproduce this - when starting in the Anomaly Explorer, loading some anomaly charts, doing a drilldown, and then switching to Dashboard.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Adds support for clicking on Anomaly Explorer charts to trigger the actions popover menu.
Anomaly Explorer
ml-anomaly-charts-actions-0001.webm
Embedding
ml-anomaly-charts-actions-embedding-0001.webm
Checklist