Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Obs Cases > Case Detail (Files tab)][SCREEN READER]: Table rows need TH[scope="row"] for SR usability: 0003 #186595

Merged
merged 5 commits into from
Jun 24, 2024
Merged

fix: [Obs Cases > Case Detail (Files tab)][SCREEN READER]: Table rows need TH[scope="row"] for SR usability: 0003 #186595

merged 5 commits into from
Jun 24, 2024

Conversation

alexwizp
Copy link
Contributor

Closes: https://github.com/elastic/observability-dev/issues/3540

rowHeader attribute was added for the following table

image

Screens

image

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.15.0 Project:Accessibility labels Jun 21, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp marked this pull request as ready for review June 21, 2024 13:23
@alexwizp alexwizp requested a review from a team as a code owner June 21, 2024 13:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 479.2KB 479.2KB +34.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

adcoelho
adcoelho approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected.

@alexwizp alexwizp merged commit bd5798c into elastic:main Jun 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexwizp @elasticmachine @kibana-ci @adcoelho