-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ResponseOps][Cases] Remove configuration's deleted custom field from template's custom fields via API #186608
[ResponseOps][Cases] Remove configuration's deleted custom field from template's custom fields via API #186608
Conversation
Pinging @elastic/response-ops-cases (Feature:Cases) |
Pinging @elastic/response-ops (Team:ResponseOps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and works as expected, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left a minimal comment 👍
x-pack/test/cases_api_integration/security_and_spaces/tests/common/configure/patch_configure.ts
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6376[✅] x-pack/test/cases_api_integration/security_and_spaces/config_basic.ts: 25/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6377[✅] x-pack/test/cases_api_integration/security_and_spaces/config_basic.ts: 25/25 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
822d78c
into
elastic:feat/case_templates
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Parent issue: #181309
This PR takes care of below scenario:
When user deletes custom fields via API, those custom fields need to be removed from templates as well.
Flaky test runner
Testing
Checklist