Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eem] rename asset_manager to entity_manager #186617

Merged
merged 16 commits into from
Jun 26, 2024

Conversation

klacabane
Copy link
Contributor

@klacabane klacabane commented Jun 21, 2024

Summary

Renames the experimental asset_manager plugin (never documented/officially released) into entity_manager. I've used node scripts/lint_ts_projects --fix and node scripts/lint_packages.js --fix to help with the procedure and also renamed manually the asset_manager references left.

The change also removes the deprecated asset_manager code, including the assetManager.alphaEnabled plugin configuration. This means entityManager plugin will be enabled by default.

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

… src/core/server/integration_tests/ci_checks'
@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

@klacabane klacabane marked this pull request as ready for review June 24, 2024 09:27
@klacabane klacabane requested review from a team as code owners June 24, 2024 09:27
@klacabane klacabane self-assigned this Jun 24, 2024
@klacabane klacabane added release_note:skip Skip the PR/issue when compiling release notes Team:obs-knowledge Observability Experience Knowledge team labels Jun 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 24, 2024
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM

@klacabane
Copy link
Contributor Author

/ci

@klacabane
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 26, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
assetManager 8 - -8
entityManager - 6 +6
total -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
assetManager 11 - -11
entityManager - 8 +8
total -3

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
assetManager 3 - -3
entityManager - 1 +1
total -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
assetManager 3.2KB - -3.2KB
entityManager - 2.1KB +2.1KB
total -1.1KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
entity-definition - 8 +8
entity-discovery-api-key - 2 +2
total +10
Unknown metric groups

API count

id before after diff
assetManager 11 - -11
entityManager - 8 +8
total -3

ESLint disabled line counts

id before after diff
assetManager 1 - -1
entityManager - 1 +1
total -0

References to deprecated APIs

id before after diff
assetManager 10 - -10
entityManager - 10 +10
total -0

Total ESLint disabled count

id before after diff
assetManager 1 - -1
entityManager - 1 +1
total -0

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @klacabane

@klacabane klacabane merged commit a493e40 into elastic:main Jun 26, 2024
40 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-knowledge Observability Experience Knowledge team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants