Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix Edit integration read only glasses #186861

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

nchaulet
Copy link
Member

Summary

Resolve #186788

Looks like I forget to push a commit, that fix typo in the hook to mark the integration page as readonly, and pass the correct condition

Tests

I manually tested it, with a user with Fleet:Read you will get the read only glasses, with a super user you will not get them.

As a superuser
Screenshot 2024-06-24 at 7 18 21 PM

As a readonly user
Screenshot 2024-06-24 at 7 19 06 PM

@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Jun 24, 2024
@nchaulet nchaulet self-assigned this Jun 24, 2024
@nchaulet nchaulet requested a review from a team as a code owner June 24, 2024 23:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet enabled auto-merge (squash) June 24, 2024 23:46
@nchaulet nchaulet changed the title [Fleet] Fix use read only context [Fleet] Fix Edit integration read only glasses Jun 25, 2024
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

Unrelated test failing should be fixed by #186898

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.4MB 1.4MB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit fdef770 into elastic:main Jun 26, 2024
21 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 26, 2024
@nchaulet nchaulet deleted the fix-readonly-hook branch June 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
6 participants