Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split visualization's uiState into two states #21644

Closed
timroes opened this issue Aug 3, 2018 · 1 comment
Closed

Split visualization's uiState into two states #21644

timroes opened this issue Aug 3, 2018 · 1 comment
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Aug 3, 2018

We currently have one state (called uiState) for visualizations to store some state in there. This will be saved with the visualization and the dashboard panel if it changes after embedding it on a dashboard (via the container state of the dashboard). Any change in it will also trigger the visualization infrastructure to cause a new render, since the request might depend on data in that state.

We want to split this up into two states: one that is temporary (i.e. never saved) and one that is permanent (i.e. saved with the visualization, and can be saved as container state on dashboard). Also when writing values to the state, it should be possible for this new state to either cause a refetch of data or not, depending on the property, i.e. the setter of the property decided if that change needs a refetch (and no longer the visualization infrastructure).

This new state must be able to serialize its data for storing it in the saved object. Since we have some special requirements here, I would try to not reuse (the already super complex) PersistedState, but rather introduce a new VisState (written in TS) for that.

@timroes timroes added chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Aug 3, 2018
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 13, 2018
@timroes
Copy link
Contributor Author

timroes commented Nov 4, 2020

This issue is no longer relevant given the expression changes we introduced in Kibana.

@timroes timroes closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant