Interceptor parity between $http and kfetch

[cjcenizal]

Goal

Consumers of kfetch will assume it's an on-par subttitute for $http. However, this is not the case because several parts of our codebase add interceptors for $http. We need to update all the places where we consume $httpProvider.interceptors to add the same interceptors for kfetch and then test thoroughly to make sure they all work as expected, in order for people to safely migrate from $http to kfetch.

• xsrf.js
• on_session_timeout.js
• on_unauthorized_response.js
• check_xpack_info_change.js

Prior discussion in #22128.

Parity example

Here's how we would update xsrf.js.

import $ from 'jquery';
import { set } from 'lodash';
import { interceptors } from 'ui/kfetch';

const xsrfRequestInterceptor = {
  request: function (opts) {
    const { kbnXsrfToken = true } = opts;
    if (kbnXsrfToken) {
      set(opts, ['headers', 'kbn-version'], internals.version);
    }
    return opts;
  }
};

export function initChromeXsrfApi(chrome, internals) {
  chrome.getXsrfToken = function () {
    return internals.version;
  };

  $.ajaxPrefilter(function ({ kbnXsrfToken = true }, originalOptions, jqXHR) {
    if (kbnXsrfToken) {
      jqXHR.setRequestHeader('kbn-version', internals.version);
    }
  });

  chrome.$setupXsrfRequestInterceptor = function ($httpProvider) {
    // Ensure all requests go through the interceptor, regardless of which fetch module is used.
    $httpProvider.interceptors.push(xsrfRequestInterceptor);
    interceptors.push(xsrfRequestInterceptor);
  };
}

[epixa]

@elastic/kibana-platform

[spalger]

Only issue I have with that example is that the interceptor is only added to kfetch when we are using angular.

[cjcenizal]

@spalger Are there cases where $setupXsrfRequestInterceptor won't be called? It looks like chrome.js will eventually call this as part of its natural bootstrap process, beginning at https://github.com/elastic/kibana/blob/master/src/ui/public/chrome/chrome.js#L82. Or are you just thinking ahead to the day when we remove Angular?

[spalger]

Oh, true, we don't use things like routing in plugins like APM but we do still setup angular. No reason to couple it to angular right now, but yeah, it should work fine.

[eliperelman]

With kfetch now being backed by the new platform http service, we should move the interceptor functionality into http. @cjcenizal I can take this on since I'm pretty familiar with each of their internals now.

[cjcenizal]

@eliperelman FYI I created #22890 to migrate on_session_timeout.js but the work stalled because I kept running into bugs. Feel free to steal from that PR if you find it useful or ignore it if not. Either way, I'll leave it open until you put up a replacement PR.

[cjcenizal]

@joshdover Can this issue be closed now?

[joshdover]

Yes, thank you.