Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip generates error in IE 11 #22956

Closed
marius-dr opened this issue Sep 12, 2018 · 8 comments
Closed

Tooltip generates error in IE 11 #22956

marius-dr opened this issue Sep 12, 2018 · 8 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@marius-dr
Copy link
Member

Kibana version: 6.40/6.4.1, master

Browser version: IE 11

Describe the bug: Mousing over the tooltip icons in IE 11 will generate the following Kibana error:

Steps to reproduce:

  1. Create a visualization in IE 11.
  2. Open the advanced pane in the buckets panel.
  3. Mouse over the ? next to JSON input.

Note: this also happens when tabbing over to the tool-tip.

Screenshots (if relevant):
Broken on IE:
tooltip_ie

It looks OK on Edge.
tooltip_edge

Also, it's all good on the 6.3 branch.

Error message:


 Fatal Error 
 Object doesn't support property or method 'contains' (https://42e3cedfd7c943a3882c78920957f713.europe-west1.gcp.cloud.es.io/bundles/vendors.bundle.js:79) 

Version: 6.4.0
Build: 17929
@marius-dr marius-dr added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. triage_needed labels Sep 12, 2018
@LeeDr
Copy link
Contributor

LeeDr commented Sep 12, 2018

@marius-dr is it just that one tooltip or any tooltip?

@marius-dr
Copy link
Member Author

All tooltips with the question mark symbol. I think they only show up in the Visualization pages

@markov00 markov00 self-assigned this Sep 13, 2018
@markov00
Copy link
Member

markov00 commented Sep 13, 2018

@marius-dr @LeeDr the problem is introduced by the following line added in EUI:
https://github.com/elastic/eui/pull/1119/files#diff-61d26088e8d1389a54bfe2d8e0181ec8R59
document.contains is not available in IE11 thus the thrown error.
It's better to have the @elastic/kibana-design team to fix this and update the EUI accordingly. I'm not sure this can be a fast fix, becase eui changed to 4.0 and maybe we need to backport the fix to a previous version. Or it's we can polyfill this in some way. @chandlerprall what do you think?

Here there is an example of polyfill for document.contains https://github.com/Financial-Times/polyfill-service/pull/183/files

@markov00 markov00 removed their assignment Sep 13, 2018
@snide
Copy link
Contributor

snide commented Sep 13, 2018

We're doing some testing. 3.0.5 works in EUI docs on IE. Guessing that there's a polyfil missing on Kibana's side. We might have a quick fix we can add though.

@markov00
Copy link
Member

@snide I was able to reproduce this directly using 3.0.5 from the EUI docs
sep-13-2018 19-33-27

@snide
Copy link
Contributor

snide commented Sep 13, 2018

We have a fix over at elastic/eui#1190

Will backport and make an EUI 3.0.6

I'll handle it.

@rashmivkulkarni
Copy link
Contributor

cc @gchaps - added the RN label.

@marius-dr
Copy link
Member Author

Can confirm as fixed by: #23006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

5 participants