-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed Kibana visualizations in Canvas #23035
Comments
Original comment by @thomasneirynck: We just introduced the Roughly, usage would look like: The only niggle is that it requires clients to use the Is there a way you can get access to the In the meantime, we're working on tidying this up, addressing some memory leaks and interaction-issues #14404. |
Original comment by @ppisljar: LINK REDACTED |
Original comment by @w33ble:
Peter's right, we just need to shove an instance of the module into the React runtime when things are initialized. I'm curious though, does this service need to be tied to Angular? I see it's using the |
Original comment by @thomasneirynck: there's been some updates. #14404 (comment). You can use |
Original comment by @timroes: I just wanted to confirm, that even with visualization trying to use the canvas pipeline in the long run, the visualize loader (documentation) is still the right way to go for embedding a visualization right now in Canvas. This function will also keep working even if we switch to using the pipeline for all visualizations. Whether or not we might want to build some deeper integration later - like loading the actual pipeline from the saved object and make this editable in Canvas - is something that I think can be discussed at a later point in time, since that would add a couple of more requirements:
|
It'd be nice to start thinking about our approach here. A couple of options I see on the table are importing as a data source only, importing as a data source and building as a canvas visualization where applicable and importing as an embeddable with support for Canvas filters. There are probably more I'm not thinking of at the moment but we really need to think through what the UX will be here. If it's an embeddable, do we link out to the config so users can easily adjust their previously configured visualization or Map? @shaunmcgough with 7.1 FF approaching and 7.2 on deck, we may want to start thinking through what's technically feasible and what that UX will look like. |
A few open issues on this, and a few things tied together. Would be nice to hit a couple at once, and there is at least one tagged to 7.2. |
I'm ready to begin tackling the UX options, but some more discussion seems necessary first. We had a lengthy discussion months ago about possible technical solutions and phases, which I think informed Peter's current PR but was also before much of Stacy's work had been completed. Suffice it all to say, it would be helpful to start shaping the first couple of iterations and consider a UX that can handle not only Visualizations but also Maps, etc., and to do so using a pattern that could be used elsewhere in Kibana (e.g. adding Canvas objects to Dashboards). |
Perhaps we could start by adding them as an element in the current add element modal? I suppose other portions of Kibana could use the actions of an embeddable to do something similar. What do you think is the easiest way to get these in the current UI constructs, or perhaps you are thinking of a new UI as well? |
Yep, my assumption is we do something simple for v1 (add to modal), but that there might be a more global Kibana solution (UX) at some point. We also need to see how the actions work in Canvas. I presume they’ll display just as Stacy demonstrated, allowing you to click an icon to edit the object in its originating app. That said, we’ve yet to nail down whether we’re displaying a reference to the object or copying it in. I presume the former but the discussion was not fully resolved last I heard it discussed. |
Closed by #39839 |
Can someone briefly explain how we can import Kibana canvas elements to Kibana dashboard? |
@Alizeh-Asim You cannot embed canvas elements into dashboards right now. This was also not part of this issue. This issue is the other way around, of embedding elements from a dashboard into a canvas workpad. For the other way around please follow #33034 |
Original comment by @w33ble:
It would be great if Canvas had a way to work with core Kibana visualizations.
Rendering Canvas inside of Dashboard might be a fair amount of work, but rendering Kibana visualizations inside of Canvas should be pretty simple. It's likely we'll want both.
Editor's Note: It's actually the other way around, getting Canvas elements into Kibana is pretty easy since there's no wrapping framework dependencies. Kibana visualizations seem pretty closely tied to Angular and with the switch away from Angular I'm hesitant to start importing Angular services.
The key benefit of this is an immediate win for our commercial reporting feature.
The text was updated successfully, but these errors were encountered: