Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tools] Implement TemplateLiteral parsing in i18n_check tool #24081

Closed
LeanidShutau opened this issue Oct 16, 2018 · 1 comment
Closed

[Tools] Implement TemplateLiteral parsing in i18n_check tool #24081

LeanidShutau opened this issue Oct 16, 2018 · 1 comment
Assignees
@LeanidShutau
Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
I18n

Comments

@LeanidShutau
Copy link
Contributor

Default message should be extracted:

i18n.translate('namespace.messageId', {
  defaultMessage: `
Default
message`,
  context: `
Message
context
`,
});
@LeanidShutau LeanidShutau added blocked Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Project:i18n labels Oct 16, 2018
@LeanidShutau LeanidShutau self-assigned this Oct 16, 2018
@LeanidShutau
Copy link
Contributor Author

Blocked by #22538

@LeanidShutau LeanidShutau added this to In progress in I18n Oct 16, 2018
@LeanidShutau LeanidShutau moved this from In progress to To do in I18n Oct 16, 2018
@LeanidShutau LeanidShutau mentioned this issue Oct 25, 2018
Merged
@LeanidShutau LeanidShutau moved this from To do to Review in I18n Oct 25, 2018
@LeanidShutau LeanidShutau moved this from Review to Backporting in I18n Oct 29, 2018
@LeanidShutau LeanidShutau moved this from Backporting to Done in I18n Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeanidShutau LeanidShutau

Labels
Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
I18n
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LeanidShutau