Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups] Improve error when "Refresh jobs" request fails due to server being unavailable #25859

Open
bhavyarm opened this issue Nov 19, 2018 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Nov 19, 2018

Kibana version: 6.5.1 BC2

Elasticsearch version: 6.5.1 BC2

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: If you are on roll up jobs screen and shut down Kibana - Kibana displays fatal error:

 error  [22:33:34.265] [error][implementation][internal] Error: stream.push() after EOF
    at readableAddChunk (_stream_readable.js:240:30)
    at StreamStream.Readable.push (_stream_readable.js:208:10)
    at StreamStream.Transform.push (_stream_transform.js:147:32)
    at ReadStream.onData (/Users/bhavyarajumandya/Desktop/BC2_6.5.1/kibana-6.5.1-darwin-x86_64/node_modules/stream-stream/lib/StreamStream.js:69:12)
    at emitOne (events.js:116:13)
    at ReadStream.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at ReadStream.Readable.push (_stream_readable.js:208:10)
    at fs.read (fs.js:2058:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:658:17)

Please note these log lines are seen while creating a rollup job. Happened while testing : #25405

Also I saw this when I shut down Kibana

screen shot 2018-11-19 at 7 27 12 am

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience :Management labels Nov 19, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management

@bhavyarm bhavyarm changed the title [error][implementation][internal] Error: stream.push() after EOF while creating rollup jobs Kibana displays fatal error if you shut down Kibana when you are rollup jobs page Nov 19, 2018
@cjcenizal cjcenizal changed the title Kibana displays fatal error if you shut down Kibana when you are rollup jobs page [Rollups] Improve error when "Refresh jobs" request fails due to server being unavailable Nov 26, 2018
@cjcenizal cjcenizal added enhancement New value added to drive a business result and removed :Management DO NOT USE bug Fixes for quality problems that affect the customer experience regression labels Nov 26, 2018
@cjcenizal
Copy link
Contributor

Thanks for spotting this @bhavyarm! This error is expected, but it can be improved. A more desirable UX would be to surface a warning toast stating that the server is unavailable instead of displaying the fatal error. I've updated this issue's title and labels to reflect this enhancement.

@yaronp68 yaronp68 added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed es-management labels Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants