Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] [k7] Make breadcrumbs more consistent #25900

Closed
spalger opened this issue Nov 20, 2018 · 2 comments
Closed

[ML] [k7] Make breadcrumbs more consistent #25900

spalger opened this issue Nov 20, 2018 · 2 comments
Assignees
Labels

Comments

@spalger
Copy link
Contributor

spalger commented Nov 20, 2018

ML currently mixes tabs and breadcrumbs, and in order to align with the guidelines set up by #25689 we should make the following changes:

  • remove breadcrumbs that are repeated by tabs
  • sub-pages within tabs will get breadcrumbs
    • going to /app/ml#/settings/calendars_list should have breadcrumbs "Machine Learning / Calendar Management"
    • the "Machine Learning" breadcrumb will always go to the root of Machine Learning (which redirects to "Job Management")

Long term we probably want to move the tab navigation in ML to be more like the side-nav we are implementing in Management. This issue is particularly short on details, and I think there is a decent amount of work to be done, so if someone has time to work on this for 7.0-alpha1 please reach out to me and we can work through the specifics of this. Thanks!

@spalger spalger added the :ml label Nov 20, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@peteharverson peteharverson changed the title [k7/ml] Make breadcrumbs more consistent [ML] [k7] Make breadcrumbs more consistent Nov 20, 2018
@peteharverson peteharverson self-assigned this Dec 6, 2018
@peteharverson peteharverson added Feature:Anomaly Detection ML anomaly detection Feature:ml-results legacy - do not use labels Dec 6, 2018
@spalger
Copy link
Contributor Author

spalger commented Dec 7, 2018

Closed by #26774

@spalger spalger closed this as completed Dec 7, 2018
@sophiec20 sophiec20 removed Feature:ml-results legacy - do not use labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants