Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Support EUI lightmode #28928

Closed
formgeist opened this issue Jan 17, 2019 · 5 comments · Fixed by #29822
Closed

[APM] Support EUI lightmode #28928

formgeist opened this issue Jan 17, 2019 · 5 comments · Fixed by #29822
Assignees
Labels
Team:APM All issues that need APM UI Team support v7.0.0

Comments

@formgeist
Copy link
Contributor

formgeist commented Jan 17, 2019

To support the official EUI lightmode the variables in https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/style/variables.ts should be replaced with the official EUI variables, and the code base should only use these.

To import the light mode

import euiLightVars from '@elastic/eui/dist/eui_theme_light.json';
@formgeist formgeist added Team:APM All issues that need APM UI Team support [zube]: Inbox labels Jan 17, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@snide
Copy link
Contributor

snide commented Jan 23, 2019

The Infra UI team has a very similar setup to APM with styled components. If you want to see an example of how they're handling it you can check it out over here. Essentially just passing down the theme as a context and loading the EUI JSON vars file as needed. #29133

@sorenlouv sorenlouv changed the title [APM] Replace custom variables file with EUI vars [APM] Support EUI lightmode Jan 31, 2019
@formgeist
Copy link
Contributor Author

@jasonrhodes fyi I merged my refactor of the colour variables we use in APM UI and replaced with the EUI light theme. #29822

@jasonrhodes
Copy link
Member

Cool, sounds like this ticket can be closed then right @formgeist ?

@formgeist
Copy link
Contributor Author

@jasonrhodes Yup, I'm fine with closing it. There's still a few custom colours left that's used for specific components of ours, which I think it's fine to leave in for now. We may have to revisit at a later point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants