Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script error when using any research field with Safari 12.0 and Polyglot extension installed #29809

Closed
ooii opened this issue Feb 1, 2019 · 3 comments
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@ooii
Copy link

ooii commented Feb 1, 2019

Kibana version:
6.5.4
Elasticsearch version:
6.5.4
Server OS version:
macOS 10.14
Browser version:
Safari 12.0
Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):
brew
Describe the bug:
Using any text field (to search or filter) generates the following error as soon as the first char is written:

Version: 6.5.4
Build: 1
Error: Script error. (:0)
onerror@https://myKibana/bundles/commons.bundle.js:1:490356

Figured out that it happens only when Polyglot Safari extension is enabled. But this behavior happens only with Kibana, I'm using Polyglot since several months.
I can't say if the extension or if Kibana is doing wrong. But since it happens only with Kibana in my case, I open a bug report here.

Steps to reproduce:

  1. Install Polyglot safari extension and enable it
  2. Start Kibana and hit Discover
  3. Start entering a text in the search field.

Expected behavior:
No bug.
Screenshots (if relevant):
image

Errors in browser console (if relevant):

[Error] Error: Script error. (:0)
onerror — commons.bundle.js:1:490357

	add (commons.bundle.js:1:449400)
	fatalError (commons.bundle.js:1:152687)
	onerror (commons.bundle.js:1:490347)
[Error] TypeError: undefined is not an object (evaluating 'settings.keyValue.charCodeAt')
	handleKeypress (injected.entry.js:8231)
[Error] Error: Script error. (:0)
	add (commons.bundle.js:1:449419)
	fatalError (commons.bundle.js:1:152687)
	onerror (commons.bundle.js:1:490347)

Provide logs and/or server output (if relevant):

Any additional context:

@nickpeihl nickpeihl added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes
Copy link
Contributor

timroes commented Feb 5, 2019

Hi,

that is sad to hear. Unfortunately we cannot give support or fix issues only occuring with specific extensions and not without them. Those extensions tend to manipulate the webpage (rewrite the DOM), and they could potentially do everything in there, so we have no chance of "making sure Kibana runs with every extension". Also if an extension destroys a webpage, that is running without the extension (i.e. the way the webpage was build), that's an issue within the extension, and must be fixed there. I can only recommend, disabling the extension for your Kibana instance, so it's not maliciously breaking the page.

Cheers,
Tim

@timroes timroes closed this as completed Feb 5, 2019
@ooii
Copy link
Author

ooii commented Feb 5, 2019

Hi @timroes, I completely understand and agree with what you've said. As mentioned before, I also opened an issue on the extension repo, so I hope they'll fix that.
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants