Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Cannot put in attribution for all source types #32821

Closed
thomasneirynck opened this issue Mar 8, 2019 · 4 comments · Fixed by #44147 or #98328
Closed

[Maps] Cannot put in attribution for all source types #32821

thomasneirynck opened this issue Mar 8, 2019 · 4 comments · Fixed by #44147 or #98328
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation

Comments

@thomasneirynck
Copy link
Contributor

Should be able to configure attribution for all source types. E.g. TMS from url, or WMS server

@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Mar 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@alexfrancoeur
Copy link

👍 I was just about to open an issue for this.

@thomasneirynck
Copy link
Contributor Author

thomasneirynck commented Oct 7, 2019

@aaronjcaldwell the implementation (#44147) only does this for TMS/WMS, but not all the layer types. I think this would be required for all the other source-types as well (e.g. index pattern layers, document layers, ...)

@thomasneirynck thomasneirynck reopened this Oct 7, 2019
@thomasneirynck
Copy link
Contributor Author

To fix this, should remove the duplicated implementations first and replacer with single attribution form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation
Projects
None yet
3 participants