Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] "View full trace" button is disabled if the root transaction is missing #33924

Open
sorenlouv opened this issue Mar 27, 2019 · 21 comments
Open
Labels
bug Fixes for quality problems that affect the customer experience needs design Team:APM All issues that need APM UI Team support

Comments

@sorenlouv
Copy link
Member

sorenlouv commented Mar 27, 2019

If the root transaction is missing it is not possible to navigate from downstream transactions to the top.

Example:
The user has a trace spanning Service A, Service B and Service C. The transaction from Service A is missing. The user has "zoomed in" on a transaction in Service C and now wants to see the full trace. However the "View full trace" button is greyed out and shows "Trace parent cannot be found". This is because the top most transaction is missing.

Instead of being stuck at a downstream transaction, the user should be able to go as far up the trace as possible. In this case that would be the transaction in Service B.

@sorenlouv sorenlouv added the Team:APM All issues that need APM UI Team support label Mar 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui

@jasonrhodes
Copy link
Member

Summarizing a few things we just talked about in Slack:

  • This is a scenario we expect may happen often, especially if end users are blocking JS
  • Changing "View Full Trace" to sometimes link to an arbitrary middle point of a trace seems confusing
  • We had at one point talked about having a "zoom out" / "go up one level" / "View Parent" button as a sibling to "View Full Trace", which could also somewhat solve this problem

@formgeist curious about your thoughts on this UX?

@formgeist
Copy link
Contributor

@axw replied on Slack:

Re the View full trace issue: just an idea, but seeing as we can detect that the root is missing, perhaps we could change the button label to "View partial trace" and add some little info or warning icon to explain? I think that would draw attention to the brokenness of the trace, while also giving the user the option of viewing what is available. Just my 2c

To which I replied;

I reckon this requires a separate warning, like for dropped spans or trace with spans with no parents. We shouldn’t change a button’s functionality on the basis of an issue like this, so I’d argue we display a callout at the top of the timeline that explains it and gives the option to go to the known parent transaction.

@alvarolobato alvarolobato added [zube]: Design Backlog enhancement New value added to drive a business result labels Mar 27, 2019
@formgeist formgeist added Team:APM All issues that need APM UI Team support and removed Team:APM All issues that need APM UI Team support labels Jun 27, 2019
@katrin-freihofner
Copy link
Contributor

@sqren could we combine all these actions (view full trace, view parent and the links to other solutions) into a context menu (https://elastic.github.io/eui/#/navigation/context-menu)?

@katrin-freihofner katrin-freihofner self-assigned this Aug 12, 2019
@sorenlouv
Copy link
Member Author

We already have most of the actions in the context menu but decided that "View full trace" was more important and needed to be outside the context menu - also because it has state and shows whether you are already on the top trace or not.

Screen Shot 2019-08-12 at 22 48 14

@katrin-freihofner
Copy link
Contributor

@sqren what do you think about putting a called by Service B for example in the line with the meta data? Or at the top of the timeline?

@sorenlouv sorenlouv changed the title [APM] Clicking "View full trace" should take the user to the highest possible level in the trace [APM] "View full trace" button is disabled if the root transaction is missing Aug 21, 2019
@sorenlouv
Copy link
Member Author

@katrin-freihofner I'm not sure I understand. Is this to solve the problem of going to the top most transaction - or is it an additional thing?

@sorenlouv
Copy link
Member Author

(btw. I updated the issue title to focus on the problem instead of a specific solution)

@katrin-freihofner
Copy link
Contributor

@katrin-freihofner I'm not sure I understand. Is this to solve the problem of going to the top most transaction - or is it an additional thing?

I was hoping it is an additional thing that solves the problem of navigating to the top most transaction :) I think it shouldn't be as prominent as the View full traceaction and I was wondering if it would make sense to place it on top of the timeline!?

@sorenlouv
Copy link
Member Author

Okay, maybe I just need to understand it a little better. We have the following trace:
Service A -> Service B > Service C > Service D

The user is zoomed in on Service D and wants to see the full trace but Service A is missing, so they can't click "View full trace" button. Instead they'll see a text "called by Service B" (because that is now that top-most transaction in the trace), or would they see "called by Service C" (because that is the parent transaction)?

How do we solve the issue of seeing the full trace (or rather: as much of the trace as possible?)?

@katrin-freihofner
Copy link
Contributor

It would be called by Service C.

I think the service map solves the issue of seeing which service is called from where. We could cross-link these two.

@sorenlouv sorenlouv added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Aug 28, 2019
@botelastic
Copy link

botelastic bot commented Dec 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the stale Used to mark issues that were closed for being stale label Dec 13, 2021
@botelastic botelastic bot removed the stale Used to mark issues that were closed for being stale label Jan 24, 2022
@akhileshpok
Copy link

@sqren - Is this a bug or a enhancement request? Thanks

@sorenlouv
Copy link
Member Author

@akhileshpok I think it falls somewhere in between :) It's not a critical bug at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience needs design Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

9 participants