Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reload on changes to disabled filters #33926

Closed
Kuermel opened this issue Mar 27, 2019 · 5 comments · Fixed by #42346
Closed

No reload on changes to disabled filters #33926

Kuermel opened this issue Mar 27, 2019 · 5 comments · Fixed by #42346
Assignees
Labels
enhancement New value added to drive a business result Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Kuermel
Copy link

Kuermel commented Mar 27, 2019

If you disable a filter in Kibana, the changes to that filter should not trigger a new search.

@timroes timroes added Feature:Filters enhancement New value added to drive a business result labels Mar 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 27, 2019
@tsullivan
Copy link
Member

Hi, can you help me understand why that would be the case? If a filter changes, then the query changes. A change to the query means that Elasticsearch is going to turn up different data.

It would be really misleading to users if they're changing controls and Kibana doesn't go back to ES to get data for the current query.

@lukasolson
Copy link
Member

@tsullivan But a disabled filter shouldn't affect the query.

@lukasolson lukasolson changed the title No reload on changes to deactivate filters No reload on changes to disabled filters Mar 29, 2019
@Kuermel
Copy link
Author

Kuermel commented Mar 29, 2019

  1. Create a new filter --> query changes
  2. Invert or edit the filter --> query changes
  3. disable filter --> query changes
  4. Invert or edit the disabled filter --> query not changes
  5. Enable the filter --> query changes

This feature request is about item 4.

@tsullivan
Copy link
Member

Ah, thanks for the clarification. Yes, that shouldn't re-query because nothing that was in-effect has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants