Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigService wrongly marks unknown config paths as handled #36423

Closed
mshustov opened this issue May 10, 2019 · 1 comment · Fixed by #36559
Closed

ConfigService wrongly marks unknown config paths as handled #36423

mshustov opened this issue May 10, 2019 · 1 comment · Fixed by #36559
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform low Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
New platform cleanup

Comments

@mshustov
Copy link
Contributor

mshustov commented May 10, 2019 •
edited
Loading

Kibana wrongly marks unknown config paths as handled if it has a string intersection with any correctly declared path.

Steps to reproduce

  • kibana.yml declares config for a path plugins.myvalueA
  • pluginA declares its configPath as plugins.myvalue
  • run Kibana

Expected outcome

Kibana fails, as kibana.yml contains unknown configuration value plugins.myvalueA

Actual outcome

Kibana works, because plugins.myvalueA is marked as handled by pluginA due to checks:
@mshustov mshustov added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform low labels May 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@mshustov mshustov mentioned this issue May 10, 2019
Merged
4 tasks
@mshustov mshustov changed the title improve config path validation ConfigService wrongly marks unknown config paths as handled May 10, 2019
@mshustov mshustov added this to To do in New platform cleanup May 10, 2019
@mshustov mshustov mentioned this issue May 14, 2019
Merged
3 tasks
@rudolf rudolf moved this from To do to In progress in New platform cleanup May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform low Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
No open projects
New platform cleanup
  
In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ConfigService wrongly marks unknown config paths as handled mshustov/kibana
2 participants
@mshustov @elasticmachine