Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] DataFrame UI cannot create value count agg with defaults #38254

Open
hendrikmuhs opened this issue Jun 6, 2019 · 3 comments
Open

[ML] DataFrame UI cannot create value count agg with defaults #38254

hendrikmuhs opened this issue Jun 6, 2019 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml

Comments

@hendrikmuhs
Copy link
Contributor

Kibana version: 7.2-SNAPSHOT

When I want to group by terms and I also like to know how many datapoints belong to 1 bucket I can use the value_count agg to create a count. However with the current UI and the chosen defaults the UI doesn't let me create it:

value_count

Workaround: If I change the group_by settings and then create the value_count agg (afterwards I can even change the value_count agg and revert the change for group_by):

value_count2

@hendrikmuhs hendrikmuhs added the Feature:Transforms ML transforms label Jun 6, 2019
@peteharverson peteharverson changed the title [ML] DataFrame UI cannon create value count agg with defaults [ML] DataFrame UI cannot create value count agg with defaults Jun 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@sophiec20
Copy link
Contributor

This occurs because of the default naming suggestions for the data frame fields. In this instance, the field user is being used as both a group-by and an agg.

The default naming for the data frame fields is as follows:

  • group-by -> user
  • aggs -> user.value_count

The workaround is to change the default field names. Because a user-facing error message is also displayed, this workaround was considered acceptable for the beta.

Consideration should be given as to how we can make this user experience better. Also take into account the users intentions, when selecting value_count is usually just to achieve the equivalent of count -- for the UI, we should perhaps make selecting count easier and perhaps move the field selection for value_count to be an advanced (JSON editing) option.

@walterra walterra self-assigned this Jun 27, 2019
@walterra walterra added the bug Fixes for quality problems that affect the customer experience label Jul 2, 2019
@walterra walterra moved this from 7.3 to 7.4 in [ML] Transforms UI (7.x) Jul 2, 2019
@walterra walterra removed the v7.3.0 label Jul 2, 2019
@walterra walterra moved this from 7.4 to Backlog in [ML] Transforms UI (7.x) Aug 22, 2019
@walterra walterra added this to Backlog in [ML] walterra Jan 29, 2020
@walterra
Copy link
Contributor

walterra commented May 8, 2020

Another suggestion how we could solve this:

  • Keep the default naming as is with dots, e.g. responsetime.avg, airline.value_count.
  • Only if we identify a conflict switch to a naming pattern with underscores, e.g. responsetime_avg, airline_value_count and display a toast message like Used airline_value_count instead of airline.value_count because of a naming conflict with airline.

This would allow us both to keep the dot based naming and not block the user and require them to rename groups or aggs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Transforms ML transforms :ml
Projects
Development

No branches or pull requests

5 participants