Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) Skip links to main content #38980

Closed
barlowm opened this issue Jun 14, 2019 · 10 comments
Closed

(Accessibility) Skip links to main content #38980

barlowm opened this issue Jun 14, 2019 · 10 comments
Assignees
Labels
loe:large Large Level of Effort Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. triage_needed WCAG A
Projects

Comments

@barlowm
Copy link
Collaborator

barlowm commented Jun 14, 2019

Actual Result:

No skip to main content (from page loading it required over 100 tab key presses to get to the main content to start working with the controls on the chart.)

Steps to reproduce:

When the Discover page loads, use the keyboard to navigate to the main content of the page:

BYPASSBLOCKS

Expected Result:

A "skip to main content" link should be added as the first link on the page (See "Skip Navigation" links in WebAIM for possible techniques) that allows the user to navigate to the main content of the page without having to tab through all the navigation elements on the page.

Meta Issue:

Accessibility Audit for Kibana 7.0

Accessibility: Make Discover Accessible for 7.0

Kibana Version:

7.0, 7.2

Relevant WCAG Criteria:

WCAG Criterion - 2.4.1Bypass Blocks - Level A

@myasonik myasonik mentioned this issue Dec 17, 2019
5 tasks
@myasonik myasonik added REASSIGN from Team:Core UI Deprecated label for old Core UI team and removed Feature:Discover Discover Application labels Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@myasonik
Copy link
Contributor

This problem is much broader than Discover (every page on Kibana) so swapping this to a Core UI problem

@ryankeairns ryankeairns added this to Backlog in Core UI Feb 10, 2020
@myasonik myasonik changed the title (Accessibility) Discover: Skip to main content (Accessibility) Skip links to main content Feb 21, 2020
@myasonik
Copy link
Contributor

This issue also blocks one of the tests added in #57821/#58122 (in test/accessibility/apps/dashboard.ts)

@myasonik myasonik mentioned this issue Feb 21, 2020
7 tasks
@ryankeairns ryankeairns moved this from Backlog to Planned in Core UI Mar 26, 2020
@ryankeairns ryankeairns self-assigned this Mar 26, 2020
@ryankeairns
Copy link
Contributor

ryankeairns commented Mar 30, 2020

I attempted to implement this in Kibana using the new EuiSkipLink and ran into issues with using anchor tags in our hash-driven URLs. When the router sees an href that begins with a # it trims everything back to the root and essentially routes the skip link back to the home page. I missed this in my initial prototype as I was only testing things out on the home page... so things appeared to work :/

There are a couple (or more) changes that will need to be in place for this to work:

  • The component destinationId prop is too restrictive. The consumer will likely need to build and pass a URL to the EuiSkipLink component.
  • Further, Kibana will need to be able to properly route requests containing anchor tags. I'm not exactly clear on the solution, but I suspect we may need to add a library for such purposes or roll a custom solution for handling anchor links in URLs.

That second point is a blocker and sounds potentially difficult. Before this proceeds any further, we would need to commit some engineering brainpower. Core UI has limited eng resources at this time, so we'll have to revisit this topic once the team is further built out.

@ryankeairns ryankeairns moved this from Planned to Backlog in Core UI Mar 30, 2020
This was referenced Apr 1, 2020
@ryankeairns ryankeairns removed this from Backlog in Core UI Jun 11, 2020
@myasonik myasonik added loe:large Large Level of Effort and removed blocked design labels Oct 1, 2020
@myasonik myasonik added this to Needs triage in a11y Dec 14, 2020
@myasonik myasonik moved this from Needs triage to Moderate in a11y Dec 16, 2020
@ryankeairns ryankeairns removed the REASSIGN from Team:Core UI Deprecated label for old Core UI team label Jan 19, 2021
@ryankeairns ryankeairns added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Jan 19, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@timductive timductive added the Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) label May 2, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@timductive timductive added this to Inbox in Discover via automation May 2, 2022
@timductive timductive moved this from Inbox to Field statistics in Discover May 2, 2022
@timductive timductive moved this from Field statistics to 8.4 [FF: July 26] in Discover May 2, 2022
@teresaalvarezsoler teresaalvarezsoler added triage Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels May 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kertal
Copy link
Member

kertal commented Aug 3, 2023

dear @ryankeairns , could you validate if this issue is still valid or can be closed?

@jughosta
Copy link
Contributor

jughosta commented Aug 3, 2023

Probably addressed via #150461

@ryankeairns
Copy link
Contributor

Ah yes, fantastic enhancement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loe:large Large Level of Effort Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. triage_needed WCAG A
Projects
a11y
Moderate
Development

No branches or pull requests

10 participants