Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify Header interface in New Platform #40185

Closed
mshustov opened this issue Jul 2, 2019 · 1 comment · Fixed by #40363
Closed

Unify Header interface in New Platform #40185

mshustov opened this issue Jul 2, 2019 · 1 comment · Fixed by #40363
Labels
chore Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jul 2, 2019

FakeRequest interface and Http.Headers interface have different types.
Any operation that works for both of them requires manual type casting. Example
@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jul 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

This was referenced Jul 2, 2019
Merged
Merged
@mshustov mshustov added this to Done (this week) in kibana-core [DEPRECATED] via automation Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fake request interface compatible with Kibana Request mshustov/kibana
2 participants
@mshustov @elasticmachine