Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Browser Unit Tests."before each" hook."before each" hook #40220

Closed
spalger opened this issue Jul 2, 2019 · 3 comments · Fixed by #40249
Closed

Failing test: Browser Unit Tests."before each" hook."before each" hook #40220

spalger opened this issue Jul 2, 2019 · 3 comments · Fixed by #40249
Labels
failed-test A test failure on a tracked branch, potentially flaky-test

Comments

@spalger
Copy link
Contributor

spalger commented Jul 2, 2019

Failure: https://kibana-ci.elastic.co/job/elastic+kibana+master/JOB=kibana-intake,node=immutable/520/testReport/junit/Browser%20Unit%20Tests/%22before%20each%22%20hook/_before_each__hook/

We've been seeing a couple flaky failures in the before each hook setup in the Karma tests. It's unfortunately cryptic, and not super flaky, but it started showing up in #37311 and has happened a number of times on master/7.x/other PRs since #34532 was merged.

image

Stacktrace:

Error: Uncaught TypeError: Cannot set property 'filters' of undefined (webpack://%5Bname%5D/./node_modules/rxjs/internal/util/hostReportError.js?:4)

I'm not totally clear what's happening here, but it seems that a subscriber somewhere is trying to do something that triggers an exception. We might be able to overwrite this module in rxjs to produce better error reporting, but it wouldn't surprise me if that doesn't actually work and the error getting through is basically as meaningless as Cannot set property 'filters' of undefined...
@spalger spalger added Team:Visualizations Visualization editors, elastic-charts and infrastructure failed-test A test failure on a tracked branch, potentially flaky-test labels Jul 2, 2019
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 2, 2019 •
edited by spalger

Pinging @elastic/kibana-app

Sorry kibana app team for the extra ping!

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@spalger spalger removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jul 2, 2019
@lizozom lizozom mentioned this issue Jul 3, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
failed-test A test failure on a tracked branch, potentially flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: Fix TS to avoid assigning filters to undefined lizozom/kibana
2 participants
@spalger @elasticmachine