Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fatal application error UI #41980

Closed
joshdover opened this issue Jul 25, 2019 · 1 comment
Closed

Add fatal application error UI #41980

joshdover opened this issue Jul 25, 2019 · 1 comment
Labels
Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Related to #18843

In the legacy platform we have the notion of a "fatal error UI" that covers the entire page when the current app encounters an error it cannot recover from.

In the new platform, we're running a single page application. It is possible for a UI app to fail, but we shouldn't need to crash the entire frontend in this situation and instead should unmount the UI app, display an error, and keep the Chrome UI showing.

This issue is to add a helper to the ApplicationService that UI apps can use to show a uniform UI for this situation. This should be used in place of the FatalErrorService which after this change, should probably only be used by Core itself.
@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jul 25, 2019
@joshdover joshdover self-assigned this Jul 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@joshdover joshdover mentioned this issue Aug 12, 2019
Merged
5 tasks
@joshdover joshdover moved this from Prioritized Backlog to Icebox in kibana-core [DEPRECATED] Sep 11, 2019
@joshdover joshdover removed their assignment Sep 19, 2019
@joshdover joshdover added the stale Used to mark issues that were closed for being stale label Jan 14, 2021
kibana-core [DEPRECATED] automation moved this from Icebox to Done (7.11) Jan 14, 2021
@joshdover joshdover removed this from Done (7.11) in kibana-core [DEPRECATED] Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform stale Used to mark issues that were closed for being stale Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshdover @elasticmachine