Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces Color Picker - Error with valid hex values #43408

Closed
jonsoini opened this issue Aug 15, 2019 · 6 comments · Fixed by #43470
Closed

Spaces Color Picker - Error with valid hex values #43408

jonsoini opened this issue Aug 15, 2019 · 6 comments · Fixed by #43470
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jonsoini
Copy link

Kibana version:
7.3.0

Elasticsearch version:
7.3.0

Server OS version:
(N/A - Elastic Cloud)

Browser version:
Chrome 76.0.3809.100 and Safari 12.1.2 (14607.3.9)

Browser OS version:
Mojave 10.14.6 (18G87)

Original install method (e.g. download page, yum, from source, etc.):
Elastic Cloud install

Describe the bug:
I receive an error message when creating or editing a Space in Kibana and when a custom color is chosen via the color picker.

UI error:
Error saving space:

(I'm able to create or edit spaces when no color value is chosen)

Steps to reproduce:

  1. Management > Spaces
  2. Create a new space, assign a custom color, like #e20074
  3. Receive error message

Expected behavior:
Should be able to create or edit a space with a custom color.

Errors in browser console (if relevant):

{statusCode: 400, error: "Bad Request",…}
error: "Bad Request"
message: "child "color" fails because ["color" with value "#E20074" fails to match the 6 digit hex color, starting with a # pattern]"
statusCode: 400
validation: {source: "payload", keys: ["color"]}
keys: ["color"]
source: "payload"

Any additional context:
An elastic solution architect confirmed the bug with their cloud instance in addition to mine.

@hemantmalik
Copy link

hemantmalik commented Aug 15, 2019

++
I get the same when tried on my cloud instance. I don't get this on a local install.

@Bargs Bargs added Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Aug 15, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@legrego legrego self-assigned this Aug 16, 2019
@legrego legrego added the bug Fixes for quality problems that affect the customer experience label Aug 16, 2019
@legrego
Copy link
Member

legrego commented Aug 16, 2019

Thanks for the report @jonsoini.

It looks like the Spaces API doesn't allow for upper-case characters to be used, but the color picker is trying to specify just that.

I've opened #43470 to address this.

@legrego
Copy link
Member

legrego commented Aug 16, 2019

v8.0: b8303e4

v7.4: 633b58e

v7.3.2: b3ba5e6

@jonsoini
Copy link
Author

23 hours?! I can't get some folks to answer a Slack message that fast. You folks are awesome!

@rashmivkulkarni
Copy link
Contributor

Tried on 7.3.2 cloud instance - works fine on 7.3.2, 7.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants