Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra + Logs UI] New platform server shim #44917

Closed
jasonrhodes opened this issue Sep 5, 2019 · 1 comment · Fixed by #45299
Closed

[Infra + Logs UI] New platform server shim #44917

jasonrhodes opened this issue Sep 5, 2019 · 1 comment · Fixed by #45299
Assignees
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Sep 5, 2019

As part of our new platform migration , we need to implement the core shim.

See here: https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#introduce-new-plugin-definition-shim

AC:

  • Infra and logs UI server start up are both using a new platform core shim
  • Implementation has been checked by the new platform team (@skaapgif probably?)

See here for more details on how this was done in APM: #34531

Notes:

Here is a list of server-side dependencies we rely on that need to be added to the shim so that we can become fully NP-compatible.

Service Uses Notes
server.plugins.xpack_main.registerFeature() 2
server.plugins.spaces.getSpaceId() 1
@jasonrhodes jasonrhodes added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Sep 5, 2019
@jasonrhodes jasonrhodes self-assigned this Sep 5, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants