Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin functional capabilities in xpack #45476

Closed
stacey-gammon opened this issue Sep 11, 2019 · 6 comments
Closed

plugin functional capabilities in xpack #45476

stacey-gammon opened this issue Sep 11, 2019 · 6 comments
Labels
Team:Operations Team label for Operations Team

Comments

@stacey-gammon
Copy link
Contributor

Just like we have plugin_functional folder in OSS, I think it would be good to have in xpack as well. I'd like to showcase/test some of the advanced capabilities.

@stacey-gammon stacey-gammon added the Team:Operations Team label for Operations Team label Sep 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@stacey-gammon
Copy link
Contributor Author

@spalger - do you know what level of effort this would be? I think we'll need this for some of the data access stuff, as async will be in x-pack and I'd like to build some sample demos on top of the async code.

@stacey-gammon
Copy link
Contributor Author

Although... if one runs with yarn start --plugin-path sample/plugin if the license isn't trial and the sample plugin is dependent on an x-pack plugin... that should just naturally work. Although I think for functional testing, it runs as oss, not trial license.

@spalger
Copy link
Contributor

spalger commented Sep 23, 2019

Adding plugin_functional tests shouldn't be too hard, but first we have to get the plugin_functional tests working again which keeps falling off my TODO list (fixing that).

Not sure what you mean by you last comment, but if a plugin requires x-pack and us loaded into OSS Kibana, the server won't start because the dependency isn't met. yarn start runs with x-pack included by default, and the license level is set by Elasticsearch which is basic by default, so unless the stuff you're looking to test required a higher license level they should work. Either way, we have flags we can pass to Elasticsearch when it starts to run it as a trial license for functional testing.

@stacey-gammon
Copy link
Contributor Author

Looks like this will be fixed by #51994 🎉

@jbudz
Copy link
Member

jbudz commented Aug 16, 2021

Closing this out with #51994 merged

@jbudz jbudz closed this as completed Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

4 participants