Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shared component for index pattern selection #47035

Closed
kertal opened this issue Oct 1, 2019 · 7 comments
Closed

Create shared component for index pattern selection #47035

kertal opened this issue Oct 1, 2019 · 7 comments
Labels
Feature:Discover Discover Application Feature:Graph Graph application feature Feature:Lens Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture

Comments

@kertal
Copy link
Member

kertal commented Oct 1, 2019

Currently we have 3 different index pattern selection components. Lens, Discover, Graph integrated their own component. The component created for Lens should be migrated to be a shareable component.

Lens index pattern selection:
Bildschirmfoto 2019-10-01 um 15 47 27

Discover index pattern selection:
image

Graph index pattern selection:
Bildschirmfoto 2019-10-01 um 18 27 43

@kertal kertal added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed release_note:enhancement labels Oct 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@flash1293
Copy link
Contributor

There is already a component like this (src/legacy/core_plugins/data/public/index_patterns/components/index_pattern_select.tsx - thanks @lizozom). We can use this ticket to track the update with the Lens popover/selectable version.

@wylieconlon wylieconlon added this to Current Backlog in Lens Nov 12, 2019
@wylieconlon wylieconlon moved this from Current Backlog to Long-term goals in Lens Nov 20, 2019
@flash1293 flash1293 added technical debt Improvement of the software architecture and operational architecture and removed enhancement New value added to drive a business result labels Aug 6, 2020
@flash1293 flash1293 moved this from Long-term goals to Tech Debt in Lens Aug 6, 2020
@ghudgins
Copy link

ghudgins commented Aug 3, 2021

would be simple to do this as the reason for separating these no longer exists (licensing)

@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@timroes
Copy link
Contributor

timroes commented Sep 29, 2021

@flash1293 @kertal Is this something we still would see any value in doing, or should we close this issue?

@kertal
Copy link
Member Author

kertal commented Sep 29, 2021

well there are discussions around that are more advanced than this issue:

#72098
#72098 (comment)

So I do think we need this, question is, what's the best issue to track it?

@flash1293
Copy link
Contributor

I still think it makes sense to unify it - I expect with more features added to data views it's going to grow in complexity

@kertal
Copy link
Member Author

kertal commented Jun 9, 2022

Closing since it was done with #127244

@kertal kertal closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Feature:Graph Graph application feature Feature:Lens Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

5 participants