Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like the z-index is off In the Saved Queries #48124

Open
XavierM opened this issue Oct 14, 2019 · 4 comments
Open

Looks like the z-index is off In the Saved Queries #48124

XavierM opened this issue Oct 14, 2019 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@XavierM
Copy link
Contributor

XavierM commented Oct 14, 2019

Looks like the z-index is off in the SIEM app as the Saved Queries popover shows above the full page frosting. To be honest, I feel like the Saved Queries popover should just dismiss automatically as that's what it does on initial click within the active popover anyway. May want to open a core bug instead of fixing here?

Discover:

SIEM

Originally posted by @spong in #47306 (comment)

@XavierM
Copy link
Contributor Author

XavierM commented Oct 14, 2019

@Bargs @TinaHeiligers what do you think?

@XavierM XavierM added the bug Fixes for quality problems that affect the customer experience label Oct 14, 2019
@TinaHeiligers
Copy link
Contributor

@XavierM I'm not sure if we want to automatically have the Saved Queries popover dismiss when deleting a saved query. Say. for example, I want to delete one from a list of saved queries and then use a different one, right now, I can delete one and still immediately have access to the others:
popover_remains_open

@spong
Copy link
Member

spong commented Oct 14, 2019

I agree @TinaHeiligers, that makes sense for providing a better UX when wanting to delete multiple queries.

As for saving queries though, the popover closes on its own once you click on the Save Query popover.

save_filter_popover

Note, since the Saved Queries popover is given focus when initially displayed, it is possible to enter a name and save the query using the keyboard, which will then result in the Saved Queries popover staying open.

saved_queries_popover_keyboard

So either way @XavierM, sounds like we'll need to fix the z-index issue present in the SIEM app.

@XavierM XavierM changed the title Looks like the z-index is off in the SIEM app as the Saved Queries popover shows above the full page frosting. To be honest, I feel like the Saved Queries popover should just dismiss automatically as that's what it does on initial click within the active popover anyway. May want to open a core bug instead of fixing here? Looks like the z-index is off In the Saved Queries Nov 1, 2019
@spong
Copy link
Member

spong commented Nov 11, 2019

This also manifests itself here within the Timeline Save Query UI:

timeline_saved_search_overlay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

3 participants