Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Improve data structures and data access in the log rate feature #48760

Closed
Kerry350 opened this issue Oct 21, 2019 · 1 comment · Fixed by #49158
Closed

[Logs UI] Improve data structures and data access in the log rate feature #48760

Kerry350 opened this issue Oct 21, 2019 · 1 comment · Fixed by #49158
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

Kerry350 commented Oct 21, 2019

Summary

In #47558 the log rate feature was refactored to account for new designs and functionality. The log rate results API endpoint currently returns one data structure, and this is transformed into various derivations needed for the UI by functions that exist in the data_formatters file (the complexity is kept to this one location).

This ticket should amend things so that the results hook returns the current data structure, as well as a new data structure that groups the results by partition first and histogram second. With the two data structures provided via the top level we should then be able to dramatically simplify the heavy lifting of the data_formatter functions. We will also increase performance.

This ticket should also simplify the handling of the fake unknown partition (this represents the '' empty string partition). The handling of this scenario and === '' comparisons should either be hoisted to a higher level, or a normalisation function introduced.

@Kerry350 Kerry350 added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
3 participants