Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Optimize expression rendering #49380

Closed
wylieconlon opened this issue Oct 25, 2019 · 2 comments
Closed

[Lens] Optimize expression rendering #49380

wylieconlon opened this issue Oct 25, 2019 · 2 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@wylieconlon
Copy link
Contributor

There are some issues that are introduced here: #48841

Specifically in Lens, we are seeing:

  • Switching an index pattern triggers new data to be fetched, even though the visualization is unchanged
  • Sometimes an error state is shown, most likely because sending two render requests in a row will cause the first to get cancelled and show an error state.

This doesn't prevent Lens from working, but the behavior is inefficient and potentially confusing.
@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon added this to After feature freeze (bug fixes, text changes) in Lens Oct 25, 2019
@wylieconlon wylieconlon moved this from After feature freeze (bug fixes, text changes) to Beta Stretch Goals in Lens Oct 28, 2019
@wylieconlon wylieconlon mentioned this issue Oct 29, 2019
Closed
@wylieconlon wylieconlon moved this from Beta Stretch Goals to Tech Debt in Lens Nov 14, 2019
@flash1293 flash1293 added the technical debt Improvement of the software architecture and operational architecture label Aug 6, 2020
@flash1293 flash1293 mentioned this issue Aug 14, 2020
Closed
43 tasks
@flash1293
Copy link
Contributor

By memoizing on the expression and caching requests, this problem is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wylieconlon @flash1293 @elasticmachine