Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary src/legacy/core_plugins/kibana eslint overrides #49547

Closed
spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #54222
Closed

Remove temporary src/legacy/core_plugins/kibana eslint overrides #49547

spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #54222
Assignees
@kertal
Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019 •
edited
Loading

In order to move forward with #49244 we needed to disable some rules in src/legacy/core_plugins/kibana. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['src/legacy/core_plugins/kibana/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/rules-of-hooks': 'off',
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger mentioned this issue Oct 28, 2019
Open
31 tasks
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal self-assigned this Jan 7, 2020
@kertal kertal mentioned this issue Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kertal kertal

Labels
chore Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup code / reenable eslint overwrite for src/legacy/core_plugins/kibana kertal/kibana
4 participants
@kertal @timroes @spalger @elasticmachine