Remove temporary x-pack/legacy/plugins/canvas eslint overrides

[spalger]

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/canvas. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/canvas/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
    'jsx-a11y/click-events-have-key-events': 'off',
  },
},

[elasticmachine]

Pinging @elastic/kibana-canvas (Team:Canvas)

[poffdeluxe]

Only the jsx-a11y/click-events-have-key-events issues currently remain.

Currently three problem areas:

/Users/poffdeluxe/Dev/kibana/x-pack/plugins/canvas/public/components/autocomplete/autocomplete.js
  231:23  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events

/Users/poffdeluxe/Dev/kibana/x-pack/plugins/canvas/public/components/element_content/invalid_element_type.js
  17:3  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events

/Users/poffdeluxe/Dev/kibana/x-pack/plugins/canvas/public/components/element_content/invalid_expression.js
  17:3  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events

✖ 3 problems (0 errors, 3 warnings)

[ThomThomson]

Closing this as it was mostly completed.