Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary x-pack/legacy/plugins/spaces eslint overrides #49569

Closed
spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #49618
Closed

Remove temporary x-pack/legacy/plugins/spaces eslint overrides #49569

spalger opened this issue Oct 28, 2019 · 1 comment · Fixed by #49618
Assignees
@legrego
Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019 •
edited
Loading

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/spaces. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/spaces/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger mentioned this issue Oct 28, 2019
Open
31 tasks
@legrego legrego self-assigned this Oct 29, 2019
@legrego legrego added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Oct 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego mentioned this issue Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@legrego legrego

Labels
chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spaces - fix react hook deps legrego/kibana
3 participants
@spalger @legrego @elasticmachine