Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task Manager] Convert plugin to New Platform #49629

Closed
gmmorris opened this issue Oct 29, 2019 · 2 comments · Fixed by #53869
Closed

[Task Manager] Convert plugin to New Platform #49629

gmmorris opened this issue Oct 29, 2019 · 2 comments · Fixed by #53869
Assignees
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.6.0

Comments

@gmmorris
Copy link
Contributor

No description provided.

@gmmorris gmmorris created this issue from a note in Make it Action (Backlog) Oct 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@gmmorris
Copy link
Contributor Author

gmmorris commented Nov 19, 2019

Caught up with @rudolf on the open blockers on moving to New Platform in Task Manager:

Schema & Serializer

SavedObjectsSerializer & SavedObjectsSchema are currently being imported directly out of core. This is still not ideal, and we plan on addressing this across the board later, but is no longer a blocker.

What is a blocker, is that they rely on the exported savedObjectSchemas configuration on uiExports (which is required to support of the task savedObjects in core services), but the plan is not to expose these on kbnServer.uiExports.savedObjectSchemas anymore.
To get around this the plan is to pass this configuration to the SavedObjectsSchema directly, rather than use the current method which uses the kbnServer.uiExports.savedObjectSchemas, which means our SavedObjects client will only know how to interact with task SavedObjects, but that's fine.

SavedObjectRepository

In the coming days we'll hopefully gain access to the repository thank to this PR: #48882

This should allow us to import and initialise our custom Repository.

callCluster

Core now exposes core.elasticsearch.createClient which should cover our custom usage of callCluster, so this should no longer be a blocker.

migrations and mapping

We don't expect these to be available until 7.8 at least, so we'll try and migrate everything to NP except for these and rely on a Legacy plugin that includes these, as this will allow us to unblock other plugins that rely on TM, such as Maps, Lens, Alerting etc.


Overall, it seems most blockers are about to get unblocked, so the focus next will be:

  1. Unblock the usage of Schema & Serializer by addressing how savedObjectSchemas is used.
  2. Use core.elasticsearch.createClient to replace how we use callCluster
  3. Once the Repository PR is merged, move to using the new core import
  4. Move the whole plugin, other than migrations and mapping to NP and unblock other plugins.

Hopefully that'll cover most of our bases, allowing us to derisk as we come closer to v8.0.0

@mikecote mikecote moved this from Backlog to Short Term in Make it Action Dec 6, 2019
@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@gmmorris gmmorris moved this from Short Term to In Progress in Make it Action Dec 31, 2019
@mikecote mikecote moved this from In Progress to Done (Ordered by most recent) in Make it Action Jan 15, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.6.0
Projects
No open projects
Make it Action
  
Done (Ordered by most recent)
Development

Successfully merging a pull request may close this issue.

5 participants