Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Firefox UI Functional Tests.test/functional/apps/dashboard/dashboard_save·js - dashboard app using legacy data dashboard save Saves on confirm duplicate title warning #51952

Closed
kibanamachine opened this issue Dec 2, 2019 · 5 comments · Fixed by #52761
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: retry.try timeout: ElementClickInterceptedError: Element <a class="euiLink euiLink--subdued euiBreadcrumb" href="#/dashboards"> is not clickable at point (100,24) because another element <div class="euiOverlayMask"> obscures it
    at Object.throwDecodedError (node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (node_modules/selenium-webdriver/lib/http.js:563:13)
    at Executor.execute (node_modules/selenium-webdriver/lib/http.js:489:26)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at onFailure (test/common/services/retry/retry_for_success.ts:28:9)
    at retryForSuccess (test/common/services/retry/retry_for_success.ts:68:13)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Dec 2, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

@legrego
Copy link
Member

legrego commented Dec 6, 2019

Another failure (untracked branch): https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/13913/

@Kerry350
Copy link
Contributor

Kerry350 commented Dec 11, 2019

We're hitting this failure on this backport #52613. Running the tests locally it seems to be very hit and miss, I get some passes, and some failures.

@legrego legrego added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Dec 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 self-assigned this Dec 11, 2019
@flash1293
Copy link
Contributor

flash1293 commented Dec 11, 2019

I looked into the code and it very much looks like the test is trying to confirm the save with a second click before the request checking whether that this is necessary has even gone through: https://github.com/elastic/kibana/blob/master/test/functional/apps/dashboard/dashboard_save.js#L58

Those clickSave() calls are not waiting for anything. I will set up a PR that waits for the confirm message to pop up before clicking a second time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants