Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reacts legacy UNSAFE_ methods with their respective alternatives #53202

Open
igoristic opened this issue Dec 16, 2019 · 1 comment
Open

Replace reacts legacy UNSAFE_ methods with their respective alternatives #53202

igoristic opened this issue Dec 16, 2019 · 1 comment
Labels
enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v8.0.0

Comments

@igoristic
Copy link
Contributor

I noticed React has been upgraded to v16.12.0 in our Kibana code base.

We should consider refactor all UNSAFE_... methods to something that won't be deprecated. Maybe something along the lines of:

UNSAFE_componentWillReceiveProps => getDerivedStateFromProps
UNSAFE_componentWillMount => componentDidMount (or maybe even constructor?)
@igoristic igoristic added enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes Team:Monitoring Stack Monitoring team v8.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elasticmachine @igoristic