Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] Improve types for index templates and ingest pipelines #53494

Closed
skh opened this issue Dec 18, 2019 · 5 comments
Closed

[EPM] Improve types for index templates and ingest pipelines #53494

skh opened this issue Dec 18, 2019 · 5 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@skh
Copy link
Contributor

skh commented Dec 18, 2019 •
edited by jen-huang

Add typescript types for the handling of ingest pipelines and index templates in the EPM server part where they are still missing.

i.e replace the anys as mentioned in
#53309 (review)

kibana/x-pack/plugins/fleet/server/services/epm/elasticsearch/ingest_pipeline/install.ts

Line 163 in 9c469fe

pipeline: any;

kibana/x-pack/plugins/fleet/common/types/models/epm.ts

Line 394 in 9c469fe

template: {

@skh skh added technical debt Improvement of the software architecture and operational architecture Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project labels Dec 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:EPM)

@skh skh mentioned this issue Dec 18, 2019
Merged
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ph
Copy link
Contributor

ph commented Oct 16, 2020

@skh is this is valid? I think yes.

@skh
Copy link
Contributor Author

skh commented Oct 26, 2020

Yes, let's keep this open.

@ph
Copy link
Contributor

ph commented Feb 15, 2021

@elastic/fleet still valid?

@jlind23
Copy link
Contributor

jlind23 commented Apr 4, 2023

Closing as not relevant anymore. Feel free to reopen if needed

@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ph @skh @jen-huang @elasticmachine @jlind23