Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] break down by - allow users to select their color palette #53661

Closed
AlonaNadler opened this issue Dec 19, 2019 · 7 comments
Closed

[Lens] break down by - allow users to select their color palette #53661

AlonaNadler opened this issue Dec 19, 2019 · 7 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Project:LensDefault Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects

Comments

@AlonaNadler
Copy link

Currently when breaking down by a field Lens uses the default color palette.
We would like to allow users to customize it by choosing from existing color palette

image

cc: @cchaos

@github-actions github-actions bot added this to Long-term goals in Lens Dec 19, 2019
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

There are two things that we should do for break down by in the short term, and one that we should delay on.

In the short term, "break down by" is always showing categorical data. Categorical data should be displayed using distinct colors for each category, and should not be displayed using a continuous scale. For example, the default colors we use in Visualize are categorical:

Screenshot 2019-04-09 17 41 44

So the two things we should do in the short term are:

  1. Let users assign a color to a specific category. For example, Kibana Airways can be purple. This can be done like Visualize already does:

color-picker

  1. Allow creation of categorical palettes from Lens, or wait for this to be supported in all of Kibana: color palettes that can be used across Kibana applications #43697

The thing to delay is continuous color palettes for Break Down by. There will be a future where users can break down by a continuous value, but we are not there yet.

@wylieconlon wylieconlon moved this from Long-term goals to Current Backlog in Lens Jan 16, 2020
@wylieconlon
Copy link
Contributor

Was not aware that charts had already done some work on this: elastic/elastic-charts#51

@wylieconlon
Copy link
Contributor

Summarizing some offline discussions I've had about categorical palettes in Lens:

  • This is not just about XY charts, I expect that pie charts will have the same color options
  • Lens is using a good default, the EUI palette.
  • Because the EUI palette is new, Lens stands out in dashboards. Sometimes users want dashboards to be cohesive, so Lens should support the default kibana palette as one of the categorical palettes.
  • For similar reasons, Lens should support a muted style such as grayscale or shades of blue as a categorical palette.
    • A common feature of these muted palettes is a highlight color such as magenta to make one series stand out
  • Lens should also support custom categorical palettes, using the same implementation as the Maps app:

Screenshot 2020-04-17 14 06 24

@wylieconlon wylieconlon moved this from Long-term goals to 7.9 in Lens May 28, 2020
@flash1293 flash1293 changed the title break down by - allow users to select their color palette [Lens] break down by - allow users to select their color palette Jun 5, 2020
@wylieconlon
Copy link
Contributor

Based on the latest discussions we will be placing this in the chart-level Lens settings for the first iteration, as opposed to being in a specific dimension. This is because both XY and pie charts need to have categorical colors, and placing it in a specific dimension does not work for pie charts.

@flash1293 flash1293 moved this from 7.9 to 7.10 in Lens Jul 2, 2020
@flash1293 flash1293 moved this from 7.10 to Long-term goals in Lens Jul 21, 2020
@flash1293 flash1293 added the enhancement New value added to drive a business result label Aug 6, 2020
@flash1293 flash1293 moved this from Long-term goals to Next minors in Lens Aug 6, 2020
@flash1293 flash1293 moved this from Lens by default to 7.11 in Lens Sep 21, 2020
@flash1293 flash1293 self-assigned this Sep 21, 2020
@flash1293 flash1293 added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 21, 2020
@flash1293
Copy link
Contributor

I would like to propose to postpone this after the "Lens by default" timeframe and go with #68404 instead. The difference is instead of having a color palette setting for the "break down by" dimension, there is a chart level setting for the same thing.

For most cases this will behave in the same way, but it solves the case if the user doesn't have a "break down by" dimension yet and wants to change the used palette (e.g. when using multiple metrics). The only cost of that I can think of is that multiple layers will use the same palette, but I don't think this would be a big impact.

Besides that, it simplifies implementation by quite a bit because we don't have to take care of a bunch of edge cases when working with multiple layers (less bugs and easier to maintain).

cc @AlonaNadler @cchaos

@flash1293 flash1293 moved this from 7.11 to Lens by default in Lens Sep 30, 2020
@flash1293 flash1293 moved this from Lens by default to 7.11 in Lens Oct 12, 2020
@flash1293 flash1293 removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Oct 12, 2020
@flash1293
Copy link
Contributor

Closed by #75309

Lens automation moved this from 7.11 to Done Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Project:LensDefault Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
No open projects
Lens
  
Done
Development

No branches or pull requests

6 participants