Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbn/config-schema should provide hostname as a separate type #55030

Open
mshustov opened this issue Jan 16, 2020 · 1 comment
Open

kbn/config-schema should provide hostname as a separate type #55030

mshustov opened this issue Jan 16, 2020 · 1 comment
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
kibana-core [DEPRECATED]

Comments

@mshustov
Copy link
Contributor

We have inconsistency in validation rules:

  • hostname is a sub-type of the string type.
  • while uri is a separate type.

We should unify the approach and extract hostname to a separate type as well.
@mshustov mshustov added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover added this to Prioritized Backlog in kibana-core [DEPRECATED] Jan 28, 2020
@joshdover joshdover moved this from Prioritized Backlog to 7.8 in kibana-core [DEPRECATED] Mar 2, 2020
@joshdover joshdover removed the blocker label Mar 2, 2020
@joshdover joshdover moved this from 7.8 to Prioritized Backlog in kibana-core [DEPRECATED] Mar 2, 2020
@joshdover joshdover moved this from Prioritized Backlog to Tech Debt Backlog in kibana-core [DEPRECATED] Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
kibana-core [DEPRECATED]
Tech Debt Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshdover @mshustov @elasticmachine